Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: resolve CI errors in shuttle-next #580

Merged
merged 27 commits into from
Mar 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a3f670a
test: compile wasm module in axum runtime test setup
oddgrd Jan 16, 2023
c4bb23c
ci: add next patch override to CI
oddgrd Jan 16, 2023
0cc8a41
Merge branch 'shuttle-next' into ci/ci-go-green
oddgrd Jan 16, 2023
ab36c24
ci: include wasm32-wasi target in rust install
oddgrd Jan 16, 2023
72ead20
fix: deployer tests where runtime fails to start
oddgrd Jan 16, 2023
90ed8fe
fix: incorrect provisioner address
oddgrd Jan 16, 2023
64433c6
Merge branch 'shuttle-next' into ci/ci-go-green
oddgrd Jan 16, 2023
b490197
feat: log service state changes in runtime
oddgrd Jan 18, 2023
651100c
feat: don't send stop req on startup failure
oddgrd Jan 18, 2023
d8f6dd6
refactor: unused imports
oddgrd Jan 18, 2023
de64d14
refactor: handling legacy panics
chesedo Jan 19, 2023
a6f3cd9
tests: deadlock less
chesedo Jan 19, 2023
5515295
refactor: fixups
chesedo Jan 19, 2023
c4ccb88
refactor: clippy suggestions
chesedo Jan 19, 2023
30dfcbc
tests: mock provisioner
chesedo Jan 20, 2023
a21c970
refactor: restore capture from 'log' and colors
chesedo Jan 20, 2023
79b6e37
refactor: clippy suggestions
chesedo Jan 20, 2023
527a91e
tests: longer wait
chesedo Jan 20, 2023
242e12e
tests: don't panic while holding lock
chesedo Jan 20, 2023
e1558b1
tests: don't panic on stream closed
chesedo Jan 20, 2023
664ceb6
tests: don't filter out state logs
chesedo Jan 20, 2023
ba7c7ef
Merge remote-tracking branch 'upstream/shuttle-next' into ci/ci-go-green
chesedo Jan 20, 2023
d328874
tests: bigger timeout
chesedo Jan 20, 2023
f2b3612
ci: remove duplicate patch
chesedo Jan 20, 2023
fa6fa05
refactor: comments
chesedo Jan 23, 2023
b02e595
Merge remote-tracking branch 'upstream/shuttle-next' into ci/ci-go-green
chesedo Jan 23, 2023
e541499
Merge remote-tracking branch 'upstream/shuttle-next' into ci/ci-go-green
chesedo Mar 10, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions admin/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }
tokio = { version = "1.22.0", features = ["macros", "rt-multi-thread"] }
toml = "0.5.9"
tracing = { workspace = true }
tracing-subscriber = { workspace = true, features = ["env-filter"] }
tracing = { workspace = true, features = ["default"] }
tracing-subscriber = { workspace = true, features = ["default", "env-filter"] }

[dependencies.shuttle-common]
workspace = true
Expand Down
4 changes: 2 additions & 2 deletions cargo-shuttle/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ tokio-tungstenite = { version = "0.17.2", features = ["native-tls"] }
toml = "0.5.9"
toml_edit = "0.15.0"
tonic = { workspace = true }
tracing = { workspace = true }
tracing-subscriber = { workspace = true, features = ["env-filter", "fmt"] }
tracing = { workspace = true, features = ["default"] }
tracing-subscriber = { workspace = true, features = ["default", "env-filter", "fmt"] }
url = "2.3.1"
uuid = { workspace = true, features = ["v4"] }
webbrowser = "0.8.2"
Expand Down
2 changes: 1 addition & 1 deletion cargo-shuttle/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ impl Shuttle {
.into_inner();

tokio::spawn(async move {
while let Some(log) = stream.message().await.expect("to get log from stream") {
while let Ok(Some(log)) = stream.message().await {
let log: shuttle_common::LogItem = log.try_into().expect("to convert log");
println!("{log}");
}
Expand Down
4 changes: 2 additions & 2 deletions deployer/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ toml = "0.5.9"
tonic = { workspace = true }
tower = { version = "0.4.13", features = ["make"] }
tower-http = { version = "0.3.4", features = ["auth", "trace"] }
tracing = { workspace = true }
tracing = { workspace = true, features = ["default"] }
tracing-opentelemetry = "0.18.0"
tracing-subscriber = { workspace = true, features = ["env-filter", "fmt"] }
tracing-subscriber = { workspace = true, features = ["default", "env-filter", "fmt"] }
uuid = { workspace = true, features = ["v4"] }

[dependencies.shuttle-common]
Expand Down
Loading