Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stabilise redeploy command #1966

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonaro00
Copy link
Member

No description provided.

@jonaro00 jonaro00 requested a review from oddgrd January 20, 2025 16:34
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR stabilizes the redeploy command functionality and improves deployment error handling in cargo-shuttle.

  • Removed re alias from Redeploy command in cargo-shuttle/src/args.rs to make it a first-class command
  • Added track_deployment_status_and_print_logs_on_fail function in cargo-shuttle/src/lib.rs to consolidate deployment status tracking
  • Improved error handling by automatically printing logs when deployments fail

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

cargo-shuttle/src/lib.rs Show resolved Hide resolved
@jonaro00 jonaro00 changed the title feat: stabilise redeploy command, print logs on fail feat: stabilise redeploy command Jan 20, 2025
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR makes a minor adjustment to improve parameter passing in the deployment logs functionality.

  • Modified track_deployment_status_and_print_logs_on_fail in cargo-shuttle/src/lib.rs to pass depl_id directly instead of by reference when fetching deployment logs
  • Change ensures proper type compatibility with the get_deployment_logs_beta API
  • Maintains existing functionality while cleaning up parameter passing semantics

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant