-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove legacy code #1962
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaro00
force-pushed
the
remove-legacy
branch
from
January 18, 2025 01:20
481b0a1
to
97ca4f5
Compare
@chesedo @oddgrd @brokad @iulianbarbu @christos-h @Kazy and other contributors, |
oddgrd
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 💥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The 💣 is here.
Removes all shuttle.rs code, keeping only what is used on shuttle.dev. 🫡
Review at your own risk (not recommended).
(Shoutout to twitter/the-algorithm#122)
onefetch -e examples
): 40315 -> 9979Breaking changes:
cargo shuttle
now targets shuttle.devnearlyall legacy crate APIsshuttle run
to use same secrets loading logic asshuttle deploy
, which is more strict, instead of using legacy logicHow has this been tested? (if applicable)
rocket_postgres
CLI local run test using DB.