Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy code #1962

Merged
merged 32 commits into from
Jan 27, 2025
Merged

chore: remove legacy code #1962

merged 32 commits into from
Jan 27, 2025

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Jan 15, 2025

Description of change

The 💣 is here.
Removes all shuttle.rs code, keeping only what is used on shuttle.dev. 🫡
Review at your own risk (not recommended).
(Shoutout to twitter/the-algorithm#122)

  • Lines of code (onefetch -e examples): 40315 -> 9979
  • Axum hello-world dependency tree: 279 -> 217
  • cargo-shuttle release build dependency tree: 485 -> 432

Breaking changes:

  • Removed legacy CLI commands and options
    • cargo shuttle now targets shuttle.dev
  • Removed nearly all legacy crate APIs
  • Removed unsupported crates & resources
  • Removed some crate features
  • Changed module location of some shuttle-common items, added "tables" feature
  • Bumped postgres version in local provisioner to 16, to match current RDS and shared databases
  • Fixed shuttle run to use same secrets loading logic as shuttle deploy, which is more strict, instead of using legacy logic

How has this been tested? (if applicable)

  • Updated CLI tests to use new platform. Added back rocket_postgres CLI local run test using DB.
  • Other than that tests were just removed ;)

@jonaro00 jonaro00 marked this pull request as ready for review January 24, 2025 17:44
greptile-apps[bot]

This comment was marked as spam.

@jonaro00
Copy link
Member Author

@chesedo @oddgrd @brokad @iulianbarbu @christos-h @Kazy and other contributors,
It has been a pleasure 🫡

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💥

cargo-shuttle/src/args.rs Show resolved Hide resolved
greptile-apps[bot]

This comment was marked as spam.

@jonaro00 jonaro00 merged commit c4e8b8a into main Jan 27, 2025
21 checks passed
@jonaro00 jonaro00 deleted the remove-legacy branch January 27, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants