Implement missing edge cases in queryArguments. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, queryArguments was partially implemented to handle the most common types I had run into, with a TODO to complete the rest. This change implements the support for the remaining argument types. Now, slices of T are mapped to "[T]!", and pointers to slices of T are mapped to "[T]", as per GraphQL specification. Add a comment pointing out that commas are omitted because they're insignificant, and we're looking to produce minified output (less bytes to send over the network). Fixes #6.
Use simpler examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, queryArguments was partially implemented to handle the most common types I had run into, with a TODO to complete the rest.
This change implements the support for the remaining argument types. Now, slices of T are mapped to "[T]!", and pointers to slices of T are mapped to "[T]", as per GraphQL specification.
Add a comment pointing out that commas are omitted because they're insignificant (see https://facebook.github.io/graphql/October2016/#sec-Insignificant-Commas), and we're looking to produce minified output (less bytes to send over the network).
Fixes #6.