Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ConstructQuery and ConstructMutation to public interface #26

Closed
wants to merge 1 commit into from

Conversation

Antipov-Anton
Copy link

I need this feature to write logs with full request data.

It's easy and beautiful to use your methods as library public interface.

@dmitshur
Copy link
Member

Thanks for the PR. This is very related to the issue shurcooL/githubv4#36.

I would like to find a way to support what you're trying to do (perform logging or tracing, and be able to include information such as the GraphQL query that was sent to remote server for execution), but I haven't found a satisfactory API to make it possible yet.

You're welcome to use this change in your fork/local version or an equivalent solution until shurcooL/githubv4#36 is resolved, but I won't be able to merge this change as is. My goal is to have a high-level and friendly API in this package, and these two functions are too low level. Let's discuss this further and look for a viable API in shurcooL/githubv4#36; then it can be implemented after we agree on a design.

I'll close this PR for now. Thanks again.

@dmitshur dmitshur closed this Sep 23, 2018
grihabor pushed a commit to grihabor/graphql that referenced this pull request Jul 20, 2022
update nhooyr/websocket dependencies v1.8.7 to fix the DDoS vulnerability issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants