Part of the text is referenced as xml, and part of the Chinese text is added #41
Conversation
| @@ -2,7 +2,7 @@ | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
| xmlns:tools="http://schemas.android.com/tools"> | |||
|
|
|||
| <uses-permission android:name="android.permission.INTERNET"/> | |||
| <uses-permission android:name="android.permission.INTERNET" /> | |||
There was a problem hiding this comment.
Can we remove all changes from this file?
Changes apart from the Chinese translation should be removed, including formatting and linting changes.
| @@ -4,15 +4,15 @@ plugins { | |||
| kotlin("plugin.serialization") version "2.1.0" | |||
| } | |||
|
|
|||
| val ktorVersion = "3.0.2" | |||
| val ktorVersion = "3.0.3" | |||
There was a problem hiding this comment.
Please revert all changes from this file.
| @@ -1,6 +1,6 @@ | |||
| #Wed Nov 06 17:43:42 IST 2024 | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip | |||
| distributionUrl=https\://mirrors.tencent.com/gradle/gradle-8.9-bin.zip | |||
There was a problem hiding this comment.
The Gradle version shouldn't be a part of this PR. Please remove all changes from this file.
| android.nonTransitiveRClass=true | ||
| android.inject.testOnly=false |
There was a problem hiding this comment.
Please remove all changes from this file.
| .padding(16.dp) | ||
| .padding(paddingValues) | ||
| .verticalScroll(rememberScrollState()), | ||
| Modifier |
There was a problem hiding this comment.
Please remove all changes due to formatting. FYI, I use ktlint for formatting and linting in the project.
|
A Chinese translation would be a great addition to the app! Also, I would request you to write the commit message (try keeping only 1 commit in this PR) in English as all other commit messages are also in English. |
|
Thank you for your correction. It is also my first time to do pr. I will regulate my behavior. |
|
Please reject this pr, I will re-standardize a pr submission |
Part of the text is referenced as xml, and part of the Chinese text is added.