Repository navigation
fix(finance): label OHIO_SOS as "Ohio Secretary of State" - #562
Conversation
FINANCE_SOURCE_LABELS had no OHIO_SOS entry, so the finance summary source line fell through to the title-caser and rendered "Ohio Sos" in both the web and mobile UI. Ohio finance shipped in #545/#546 and is live in prod, so this was user-visible. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 26 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
FINANCE_SOURCE_LABELSinpackages/api-client/src/format.tshad noOHIO_SOSentry, so the finance summary source line fell through to the fallback title-caser and rendered "Ohio Sos" in both the web and mobile UI. Ohio finance shipped in #545/#546 and is live in prod, so this was user-visible today.Adds
OHIO_SOS: "Ohio Secretary of State", placed alphabetically betweenNEW_MEXICO_CFISandOKLAHOMA_GUARDIAN, and extends the existingfinanceSourceLabeltest.The key matches the backend enum in
backend/src/pipeline/address/ballotLookupFinanceShared.ts:95. Mobile shares the sameFinanceSummaryCardand api-client, so it picks up the fix too.Testing
npm run typecheckinfrontend/— passesnpm testinfrontend/— 460 tests / 41 files pass (the api-client tests run through frontend's vitest config)Note
OHIO_CAMPAIGN_FINANCE_ENABLEDwas missing from the localbackend/.env(not in this repo), which hides the Ohio finance card locally. Added out-of-band along with the sync flag — prod was unaffected sincerender.yamlalready sets it.🤖 Generated with Claude Code