Fix <Iterate> render function parameter typing not inferring correctly
#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly in conjunction with `initialValue` semantics
shtaif
pushed a commit
that referenced
this pull request
Jan 5, 2025
## [0.3.0](v0.2.0...v0.3.0) (2025-01-05) ### Features * add a convenience alias export `<It>` for `<Iterate>` ([#19](#19)) ([679cb23](679cb23)) * add an exposed `MaybeAsyncIterable` helper generic type ([#25](#25)) ([dd06927](dd06927)) * make `useAsyncIterState` iterable's type more accurate ([#23](#23)) ([bd75364](bd75364)) ### Bug Fixes * `<Iterate>` render function parameter typing not inferring correctly in conjunction with `initialValue` with plain values semantics ([#24](#24)) ([fe45bbb](fe45bbb)) * make iterators of the `useAsyncIterState` hook's iterable individually closable to prevent leaving around unsettled promises ([#22](#22)) ([25e1ab5](25e1ab5)) * yielding consecutive identical values causes unnecessary re-renders for `useAsyncIter` and `<Iterate>` in misalignment with `React.useState` ([#21](#21)) ([2a35f72](2a35f72)) ### Refactor * fix import path of `iterateFormatted` on package's public export ([#17](#17)) ([f3481e6](f3481e6)) * various misc refactorings ([#26](#26)) ([20af9b0](20af9b0)) ### Tests * add tests for rapid yielding iterables value batching for `useAsyncIter` and `<Iterate>` ([#20](#20)) ([ebcbfd4](ebcbfd4))
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
<Iterate>'s render function parameter type not inferred correctly whenvalueprop is given a plain value, in which case it was still consideringinitialValue's type (orundefinedon lack of it) as a possibility in the iteration result object's value (but that can't happen since we have a plain non-iterable value which it will render as-is immediately).