Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev joke #484

Merged
merged 5 commits into from
Oct 3, 2020
Merged

Dev joke #484

merged 5 commits into from
Oct 3, 2020

Conversation

him2016
Copy link
Contributor

@him2016 him2016 commented Oct 2, 2020

No description provided.

@debone
Copy link
Collaborator

debone commented Oct 3, 2020

Thank you for your contribution! We welcome jokes but your second joke is a duplicated :) Please make sure the joke is not in the file already

Also, the first one requires some work as the joke is not quite there.

@him2016
Copy link
Contributor Author

him2016 commented Oct 3, 2020

Have updated it. Pls check.

@debone
Copy link
Collaborator

debone commented Oct 3, 2020

Thanks. I see think now these are fine but the second one is missing a punchline. Can you improve the wording or remove it?

@him2016
Copy link
Contributor Author

him2016 commented Oct 3, 2020

Have removed the second one. Pls check.

@debone
Copy link
Collaborator

debone commented Oct 3, 2020

Thank you!

@debone debone merged commit 3025eb6 into shrutikapoor08:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@him2016 @debone