Modify FuncchainSettings.llm to str type#33
Open
danielpodrazka wants to merge 1 commit intoshroominic:mainfrom
Open
Modify FuncchainSettings.llm to str type#33danielpodrazka wants to merge 1 commit intoshroominic:mainfrom
str type#33danielpodrazka wants to merge 1 commit intoshroominic:mainfrom
Conversation
The current union of `BaseChatModel | str` is causing a failure when we try to set LLM in `.env` because it tries to call a `BaseChatModel` function on validation, which doesn't exist if the passed value is of `str` type
str type.str type
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current union of
BaseChatModel | strinFuncchainSettingsis causing a failure when we try to setLLMin.envbecause it tries to call aBaseChatModelfunction on validation, which doesn't exist if the passed value is ofstrtype. Changing it tostrfixes the issue although I've noticed thatllmis assignedBaseChatModelin some places so changing it tostrdoesn't fully describe what the variable can be. However, for the sake of the fix and for a working.envreading, I think it's a good trade-off.The error that this change is fixing:
To replicate the error:
LLM=somethingfrom funcchain import settings