Allow for QOS/DSCP to be set #172
Open
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello, thank you for your PR. Should there be a range limit on the value of uc.Dscp? |
r3inbowari
reviewed
Jan 17, 2024
Author
|
sure, happy to change it to that.
…On Wed, Jan 17, 2024 at 7:02 AM r3inbowari ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In speedtest.go
<#172 (comment)>:
> @@ -29,6 +29,7 @@ var (
noDownload = kingpin.Flag("no-download", "Disable download test.").Bool()
noUpload = kingpin.Flag("no-upload", "Disable upload test.").Bool()
pingMode = kingpin.Flag("ping-mode", "Select a method for Ping. (support icmp/tcp/http)").Default("http").String()
+ dscp = kingpin.Flag("dscp", "type of service field in IP header").Short('Q').Int()
Would it be better to use qos instead of dscp?
—
Reply to this email directly, view it on GitHub
<#172 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABQCURJ5EKAKTUTHFH2PIDYO7RXTAVCNFSM6AAAAABB6UP2SGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMRXGUYDQMRVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
Done |
Collaborator
|
Good work. Additionally, we need to ensure that all platforms compile successfully. refhttps://learn.microsoft.com/en-us/answers/questions/1137447/hot-to-set-traffic-class-of-ipv6-socket |
r3inbowari
reviewed
Jan 18, 2024
| noDownload = kingpin.Flag("no-download", "Disable download test.").Bool() | ||
| noUpload = kingpin.Flag("no-upload", "Disable upload test.").Bool() | ||
| pingMode = kingpin.Flag("ping-mode", "Select a method for Ping. (support icmp/tcp/http)").Default("http").String() | ||
| tos = kingpin.Flag("tos", "type of service field in IP header").Short('Q').Int() |
Collaborator
There was a problem hiding this comment.
Suggested change
| tos = kingpin.Flag("tos", "type of service field in IP header").Short('Q').Int() | |
| tos = kingpin.Flag("tos", "type of service field in IP header").Short('Q').Uint8() |
Limit the size of the tos field to 8 bits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.