Skip to content

Commit

Permalink
improve consistency of ui.update and element.update
Browse files Browse the repository at this point in the history
  • Loading branch information
falkoschindler committed Oct 27, 2022
1 parent 0d7392c commit afa3236
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion nicegui/elements/element.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,5 +109,5 @@ def tooltip(self, text: str, *, props: str = ''):
return self

def update(self) -> None:
if globals.loop is not None:
if globals.loop and globals.loop.is_running():
create_task(self.view.update())
10 changes: 2 additions & 8 deletions nicegui/update.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
from typing import List

from . import globals
from .elements.element import Element
from .task_logger import create_task


def update(self, *elements: List[Element]) -> None:
if not (globals.loop and globals.loop.is_running()):
return
def update(self, *elements: Element) -> None:
for element in elements:
create_task(element.view.update())
element.update()

0 comments on commit afa3236

Please sign in to comment.