Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redis to Valkey Part 2 #1830

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Update Redis to Valkey Part 2 #1830

merged 4 commits into from
Nov 22, 2024

Conversation

ronycsdu
Copy link
Collaborator

No description provided.

Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #1830 will not alter performance

Comparing INS-33198-redis-to-valkey-part-2 (b6ad0d5) with main (395ca02)

Summary

✅ 36 untouched benchmarks
🆕 2 new benchmarks
⁉️ 2 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main INS-33198-redis-to-valkey-part-2 Change
⁉️ redis_cluster_ports_rewrite 18.2 µs N/A N/A
⁉️ redis_filter 22.8 µs N/A N/A
🆕 valkey_cluster_ports_rewrite N/A 18.1 µs N/A
🆕 valkey_filter N/A 22.6 µs N/A

@ronycsdu ronycsdu marked this pull request as ready for review November 21, 2024 23:31
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rukai rukai enabled auto-merge (squash) November 22, 2024 00:16
@rukai rukai merged commit 2bb4ed3 into main Nov 22, 2024
40 of 41 checks passed
@rukai rukai deleted the INS-33198-redis-to-valkey-part-2 branch November 22, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants