SG-39698 ensure_functions copied from python-api with deprecation warning #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… says tha it will be removed soon
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1042 +/- ##
=======================================
Coverage 79.78% 79.79%
=======================================
Files 198 198
Lines 20773 20773
=======================================
+ Hits 16574 16576 +2
+ Misses 4199 4197 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
carlos-villavicencio-adsk
approved these changes
Jul 17, 2025
julien-lang
approved these changes
Jul 18, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR copies deprecated ensure_* utility functions from python-api to the local sgutils.py module as a temporary bridge while these functions are being phased out. The functions are marked with deprecation warnings to encourage migration to built-in Python string methods.
- Removes dependency on external python-api sgutils module
- Adds local implementations of
ensure_binary,ensure_str, andensure_textfunctions - Implements comprehensive deprecation warnings for both module-level and function-level usage
eduardoChaucaGallegos
deleted the
ticket/SG-39698-deprecation-warning-sgutils
branch
This was referenced Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ensure_* functions were copied from python-api to sgutils.py, as they are being removed from python-api but are likely still in use elsewhere in the codebase.
A deprecation warning was added to each function to indicate they will be removed in a future version.