Bump Ruby to 3.3#41
Conversation
zaratan
commented
May 10, 2026
zaratan
commented
- Bumped project Ruby to 3.3
- Updated ruby test Matrix to not EOL rubies
- Updated Tapioca/Sorbet/Rubocop
|
To help you review : Anything in sorbet and docs is autogenerated by gems. The actual changes are small. |
| spec.add_dependency 'zeitwerk', '~> 2.2' | ||
|
|
||
| spec.add_development_dependency 'bundler' | ||
| spec.metadata = { 'rubygems_mfa_required' => 'true' } |
There was a problem hiding this comment.
BTW : This was burning the config on line 20-24
tzucm
left a comment
tzucm
left a comment
There was a problem hiding this comment.
Left a few minor comments. Thanks for the effort on this upgrade, great work!
| Module: ShotgridApiRuby::Auth::Validator | ||
|
|
||
| — Documentation by YARD 0.9.28 | ||
| — Documentation by YARD 0.9.43 |
There was a problem hiding this comment.
I noticed that the docs/ (Yard files) directory is already included in .gitignore, but these files are still being tracked. Could we untrack them to prevent this noise in future PRs?
There was a problem hiding this comment.
This was a workaround introduced a while back and completely willing to remove/change it.
I wanted the ruby doc for this gem to be bundled into the repo for it to be accessible on Github Pages. I'm unsure if it's still published on Github pages and I can't see any URL to the doc in the gemspec so that flow is probably broken. How the flow works right now :
- Someone clone the gem repo and install the git hooks (via
overcommit) - Someone commit => The pre-commit git hooks run (
.overcommit.ymlline 15-17 =>bin/generate_and_add_documentation=>yard doc --plugin sorbet -o docs && git add -f docs) and this will write and commit the docs into the repo.
This (kind of) ensure the doc stay up to date. Should I redo it now it would probably be actions doing it and it would be much cleaner, but… 🤷
Should we address this in this PR ? (The MacOS file is also created/added because of this flow I can definitely change the git add -f docs part of the command to ignore the .DS_Store but that would complexify a command that we might end up scrapping in the end)
There was a problem hiding this comment.
What we can/should do is either :
- Scrap all this directly in this PR. Do not generate the docs and people can do it if they need to.
- Do this in another PR to separate issues
- Keep it and fix the Github Pages issue together so the documentation link appears on rubygems.
There was a problem hiding this comment.
Could we please delete this macOS file? Also, we should probably add these types of files to the .gitignore. Thanks!
| spec.add_dependency 'zeitwerk', '~> 2.2' | ||
|
|
||
| spec.add_development_dependency 'bundler' | ||
| spec.metadata = { 'rubygems_mfa_required' => 'true' } |
|
@tzucm Thanks for the review ! Tell me what you want me to do regarding the docs. Just so you know I have 3 other PRs parked and waiting this approval to be submitted (Upgrading safe deps, Upgrading to Faraday 2 and moving out of prettier for SyntaxTree (which prettier-ruby was based upon) which allowed me to remove all JS from this repo) |
2 participants
