Fix misused super in CACertsHTTPSConnection and CACertsHTTPSHandler #394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash when uploading a thumbnail.
I've isolated the regression to shotgun_api3-3.8.2, more specifically this commit:
https://github.com/shotgunsoftware/python-api/pull/368/files?diff=split&w=0
The issue come from the change in the parent class of
CACertsHTTPSHandler
.It was changed from
HTTPSHandler
toHTTPHandler
.This change is weird as the class re-implement
https_open
which don't exist inHTTPHandler
.I assume this was done because without changing the parent class, we get the following error:
The reason we get this error is because of how some lines where converted to
super
calls.They were converted from:
To:
But they should be:
Passing
self
toHTTPSHandler.__init__
will set thedebuglevel
keyword argument, hence the crash.I hope this helps!