SG-35561 export csv python changes #386
Open
+47
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test cases dependes on changes made in |
kuldeepgudekar
requested review from
julien-lang,
barbara-darkshot and
carlos-villavicencio-adsk
and removed request for
julien-lang and
barbara-darkshot
There was a problem hiding this comment.
Let's add some documentation in the /docs directory. This will end up in the docs site.
Comment on lines
+1915
to
+1917
| params = dict( | ||
| format=format, page_id=page_id | ||
| ) |
There was a problem hiding this comment.
Is it possible to add some data validations before sending it to the server? i.e. expected format values or page_id type.
There was a problem hiding this comment.
Thanks @carlos-villavicencio-adsk for your comments. I have these validations in api_handler.rb in another pull request like validations for other functions.
carlos-villavicencio-adsk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes change for the new API enpoint export_page and test case around it. The report download test case is unavailable due to the following reasons: