SG-38119 Release v3.8.0. Make payload optimization default #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-villavicencio-adsk
changed the title
julien-lang
requested changes
Feb 11, 2025
| self.assertEqual(result, expected) | ||
|
|
||
| @mock.patch.dict(os.environ, {"SHOTGUN_API_ENABLE_ENTITY_OPTIMIZATION": "1"}) | ||
| @mock.patch("shotgun_api3.shotgun.SHOTGUN_API_DISABLE_ENTITY_OPTIMIZATION", False) |
There was a problem hiding this comment.
Why do we want to keep the patch here? Instead of removing the line since it's enabled by default?
There was a problem hiding this comment.
It seems since the module shotgun is loaded in memory, the global module variable value is kept. So this mocking reverts the value to the original value.
Co-authored-by: Julien Langlois <16244608+julien-lang@users.noreply.github.com>
eduardoChaucaGallegos
approved these changes
Feb 11, 2025
julien-lang
approved these changes
Feb 11, 2025
carlos-villavicencio-adsk
deleted the
make-payload-optimization-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables by default: