Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SG-34087 - Rebranding #321

Merged
merged 8 commits into from
Mar 20, 2024
Merged

SG-34087 - Rebranding #321

merged 8 commits into from
Mar 20, 2024

Conversation

juanburgosautoglb
Copy link
Contributor

Change all the shotgrid/shotgun occurrences in the repository.

julien-lang
julien-lang requested changes Jan 17, 2024
View reviewed changes
HISTORY.rst Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
SECURITY.md Show resolved Hide resolved
julien-lang
julien-lang reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to respect the line width rule when exists in the file

README.md Outdated Show resolved Hide resolved
docs/authentication.rst Outdated Show resolved Hide resolved
docs/advanced/packaging.rst Outdated Show resolved Hide resolved
docs/cookbook/examples/svn_integration.rst Outdated Show resolved Hide resolved
docs/index.rst Show resolved Hide resolved
shotgun_api3/shotgun.py Outdated Show resolved Hide resolved
tests/example_config Outdated Show resolved Hide resolved
julien-lang
julien-lang requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check last changes. I see a lof of "eaten spaces"

shotgun_api3/shotgun.py Outdated Show resolved Hide resolved
julien-lang
julien-lang requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. We are almost there.

HISTORY.rst Outdated Show resolved Hide resolved
HISTORY.rst Outdated Show resolved Hide resolved
docs/cookbook.rst Outdated Show resolved Hide resolved
docs/cookbook/smart_cut_fields.rst Outdated Show resolved Hide resolved
julien-lang
julien-lang reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I checked the branch and I still see 2 references to ShotGrid:

  • setup.py
  • software_credits

julien-lang
julien-lang approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlos-villavicencio-adsk carlos-villavicencio-adsk merged commit 94718c4 into master Mar 20, 2024
24 checks passed
@carlos-villavicencio-adsk carlos-villavicencio-adsk deleted the ticket/SG-34087-rebranding branch March 20, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-lang julien-lang julien-lang approved these changes

@carlos-villavicencio-adsk carlos-villavicencio-adsk Awaiting requested review from carlos-villavicencio-adsk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanburgosautoglb @julien-lang @carlos-villavicencio-adsk