SG-19308 bundle certifi #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -0,0 +1,3 @@ | |||
| from .core import contents, where | |||
There was a problem hiding this comment.
'.core.contents' imported but unused
'.core.where' imported but unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bundles the Python module certifi with the API. The reason for doing this is so that the API ships with the latest certs at the time, and uses them by default. This should hopefully remove the issue where clients are using old Python interpreters that are bundled with out of date certs.
I haven't updated/created a software credits and requirements file for this change, as we are going to be adding one anyway as part of a separate ticket, so I felt it was better to leave that for now.