Skip to content

feat(hotfix): Maven Configuration for JaCoCo Plugin #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2025
Merged

feat(hotfix): Maven Configuration for JaCoCo Plugin #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9a0aec
maven: Removed unused and unnecessary dependencies in pom.xml
shortthirdman Apr 15, 2025
6410b8b
core(config): Changes to JaCoCo configuration for file exclusion
shortthirdman May 2, 2025
961140f
core: Added new problem statement with unit tests
shortthirdman May 2, 2025
6c0503d
core(config): Configure JaCoCo plugin configuration with package excl…
shortthirdman May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 20 additions & 42 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
<executions>
<execution>
<id>attach-sources</id>
<phase>package</phase>
<phase>install</phase>
<goals>
<goal>jar-no-fork</goal>
<goal>test-jar-no-fork</goal>
Expand All @@ -145,7 +145,6 @@
</profiles>

<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand All @@ -169,34 +168,17 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.13.0</version>
<configuration>
<fork>true</fork>
<source>${java.version}</source>
<target>${java.version}</target>
<fork>true</fork>
<showWarnings>false</showWarnings>
<showDeprecation>false</showDeprecation>
<encoding>${project.build.sourceEncoding}</encoding>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-help-plugin</artifactId>
<version>3.0.1</version>
<executions>
<execution>
<id>show-profiles</id>
<phase>compile</phase>
<goals>
<goal>active-profiles</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<version>2.22.2</version>
<executions>
<execution>

</execution>
</executions>
<configuration>
<encoding>${project.build.sourceEncoding}</encoding>
<reportFormat>brief</reportFormat>
Expand All @@ -222,14 +204,7 @@
<threadCount>10</threadCount>
<printSummary>true</printSummary>
<reportFormat>plain</reportFormat>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jxr-plugin</artifactId>
<version>3.3.0</version>
<configuration>
<docTitle>${project.description}</docTitle>
<testFailureIgnore>true</testFailureIgnore>
</configuration>
</plugin>
<plugin>
Expand All @@ -241,7 +216,7 @@
<!-- <outputDirectory>${project.reporting.outputDirectory}/jacocoHtml</outputDirectory>-->
<title>${project.description} ${project.version}</title>
<excludes>
<exclude>*com.shortthirdman.quickstart.common.*</exclude>
<exclude>com/shortthirdman/quickstart/common/**/*.java</exclude>
</excludes>
</configuration>
<executions>
Expand All @@ -254,10 +229,11 @@
</execution>
<execution>
<id>coverage-report</id>
<phase>post-integration-test</phase>
<!-- <phase>post-integration-test</phase> -->
<goals>
<goal>report</goal>
</goals>
<phase>test</phase>
</execution>
<execution>
<id>coverage-check</id>
Expand All @@ -267,36 +243,39 @@
<phase>test</phase>
<configuration>
<rules>
<rule>
<rule implementation="org.jacoco.maven.RuleConfiguration">
<element>PACKAGE</element>
<excludes>
<exclude>com.shortthirdman.quickstart.common.*</exclude>
<exclude>com.shortthirdman.quickstart.common</exclude>
</excludes>
<limits>
<limit>
<limit implementation="org.jacoco.report.check.Limit">
<counter>LINE</counter>
<value>COVEREDRATIO</value>
<minimum>0.6</minimum>
</limit>
<limit>
<limit implementation="org.jacoco.report.check.Limit">
<counter>INSTRUCTION</counter>
<value>COVEREDRATIO</value>
<minimum>0.6</minimum>
</limit>
</limits>
</rule>
<rule>
<rule implementation="org.jacoco.maven.RuleConfiguration">
<element>BUNDLE</element>
<excludes>
<exclude>com.shortthirdman.quickstart.common</exclude>
</excludes>
<limits>
<limit>
<limit implementation="org.jacoco.report.check.Limit">
<counter>INSTRUCTION</counter>
<value>COVEREDRATIO</value>
<minimum>0.80</minimum>
<minimum>0.75</minimum>
</limit>
<limit>
<limit implementation="org.jacoco.report.check.Limit">
<counter>CLASS</counter>
<value>MISSEDCOUNT</value>
<maximum>1</maximum>
<maximum>10</maximum>
</limit>
</limits>
</rule>
Expand All @@ -306,6 +285,5 @@
</executions>
</plugin>
</plugins>
</pluginManagement>
</build>
</project>
51 changes: 51 additions & 0 deletions src/main/java/com/shortthirdman/quickstart/hackerrank/RequestMaximizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
package com.shortthirdman.quickstart.hackerrank;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

/**
* Capacity Doubling Optimization - The Endpoint Upgrade Dilemma
* @author shortthirdman
*/
public class RequestMaximizer {

public long getMaxRequests(List<Integer> endpointCapacity, List<Integer> incomingTraffic, int k) {
// --- Defensive Checks ---
if (endpointCapacity == null || incomingTraffic == null) {
throw new IllegalArgumentException("Input lists cannot be null.");
}

if (endpointCapacity.size() != incomingTraffic.size()) {
throw new IllegalArgumentException("List sizes must match.");
}

if (k < 0) {
throw new IllegalArgumentException("k cannot be negative.");
}

int n = endpointCapacity.size();
List<Integer> benefitList = new ArrayList<>();
long totalHandled = 0;

for (int i = 0; i < n; i++) {
int capacity = endpointCapacity.get(i);
int traffic = incomingTraffic.get(i);

int handledNormally = Math.min(capacity, traffic);
int handledIfDoubled = Math.min(capacity * 2, traffic);

totalHandled += handledNormally;
benefitList.add(handledIfDoubled - handledNormally);
}

// Sort and apply k upgrades
benefitList.sort(Collections.reverseOrder());

for (int i = 0; i < Math.min(k, n); i++) {
totalHandled += benefitList.get(i);
}

return totalHandled;
}
}
141 changes: 141 additions & 0 deletions src/test/java/com/shortthirdman/quickstart/hackerrank/RequestMaximizerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
package com.shortthirdman.quickstart.hackerrank;

import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

import java.util.List;

import static org.junit.jupiter.api.Assertions.*;

class RequestMaximizerTest {

RequestMaximizer app;

@BeforeEach
void setUp() {
app = new RequestMaximizer();
}

@AfterEach
void tearDown() {
}

// --- ✅ Positive Tests ---

@Test
void testBasicCase() {
List<Integer> cap = List.of(10, 4, 3, 7);
List<Integer> traffic = List.of(3, 10, 4, 5);
int k = 2;
assertEquals(20, app.getMaxRequests(cap, traffic, k));
}

@Test
void testKIsZero() {
List<Integer> cap = List.of(5, 10);
List<Integer> traffic = List.of(10, 10);
int k = 0;
assertEquals(15, app.getMaxRequests(cap, traffic, k));
}

@Test
void testKMoreThanN() {
List<Integer> cap = List.of(2, 3);
List<Integer> traffic = List.of(6, 7);
int k = 5;
assertEquals(10, app.getMaxRequests(cap, traffic, k));
}

@Test
void testZeroTraffic() {
List<Integer> cap = List.of(5, 10, 8);
List<Integer> traffic = List.of(0, 0, 0);
int k = 2;
assertEquals(0, app.getMaxRequests(cap, traffic, k));
}

@Test
void testAllTrafficLessThanCapacity() {
List<Integer> cap = List.of(10, 10, 10);
List<Integer> traffic = List.of(1, 2, 3);
int k = 2;
assertEquals(6, app.getMaxRequests(cap, traffic, k));
}

@Test
void testAllTrafficMoreThanCapacity() {
List<Integer> cap = List.of(2, 2, 2);
List<Integer> traffic = List.of(10, 10, 10);
int k = 1;
assertEquals(8, app.getMaxRequests(cap, traffic, k));
}

// --- ❌ Negative Tests ---

@Test
void testNullCapacityList() {
assertThrows(IllegalArgumentException.class, () -> app.getMaxRequests(null, List.of(1, 2, 3), 2));
}

@Test
void testNullTrafficList() {
assertThrows(IllegalArgumentException.class, () -> app.getMaxRequests(List.of(1, 2, 3), null, 2));
}

@Test
void testMismatchedListSize() {
List<Integer> cap = List.of(1, 2);
List<Integer> traffic = List.of(5, 6, 7);
assertThrows(IllegalArgumentException.class, () -> app.getMaxRequests(cap, traffic, 1));
}

@Test
void testNegativeK() {
List<Integer> cap = List.of(5, 5);
List<Integer> traffic = List.of(6, 6);
assertThrows(IllegalArgumentException.class, () -> app.getMaxRequests(cap, traffic, -1));
}

// --- 🧨 Edge Cases ---

@Test
void testEmptyLists() {
List<Integer> cap = List.of();
List<Integer> traffic = List.of();
int k = 0;
assertEquals(0, app.getMaxRequests(cap, traffic, k));
}

@Test
void testSingleEndpoint() {
List<Integer> cap = List.of(2);
List<Integer> traffic = List.of(5);
int k = 1;
assertEquals(4, app.getMaxRequests(cap, traffic, k));
}

@Test
void testAllCapacityZero() {
List<Integer> cap = List.of(0, 0, 0);
List<Integer> traffic = List.of(5, 5, 5);
int k = 2;
assertEquals(0, app.getMaxRequests(cap, traffic, k));
}

@Test
void testDoublingDoesNotHelp() {
List<Integer> cap = List.of(10, 10, 10);
List<Integer> traffic = List.of(5, 5, 5);
int k = 3;
assertEquals(15, app.getMaxRequests(cap, traffic, k));
}

@Test
void testLargeNumbers() {
List<Integer> cap = List.of(1_000_000_000, 1_000_000_000);
List<Integer> traffic = List.of(2_000_000_000, 2_000_000_000);
int k = 1;
assertEquals(3_000_000_000L, app.getMaxRequests(cap, traffic, k));
}
}