Fix knob sync: use AMY reset defaults for all knobs#698
Merged
Conversation
bwhitman
force-pushed
the
claude/trusting-nightingale
branch
from
c99d3e7 to
237919d
Compare
Initialize all UI knobs to AMY's true reset_osc defaults so that values omitted by EVENT_FROM_OSC_ARRAY (because they match the reset state) still display correctly. Adds amy_default field to every knob definition and initializes set_knobs_from_events() working variables from those defaults instead of null/0. Also fixes: - sync knobs from AMY state on first page load (no editor_state) - replace hardcoded knob reset in Clear with sync from AMY - fix event.Freq typo (capital F) preventing LFO freq sync - fix event.wave falsy-zero check skipping SINE wave - pin amy submodule to include osc reset before patch load (#572) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bwhitman
force-pushed
the
claude/trusting-nightingale
branch
from
237919d to
9fea1c7
Compare
Collaborator
|
Nice!
…On Tue, Mar 3, 2026 at 17:39 Brian Whitman ***@***.***> wrote:
Merged #698 <#698> into main.
—
Reply to this email directly, view it on GitHub
<#698 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEGZUITXLCKANCNWPWUQB34O5NKHAVCNFSM6AAAAACWF7EBWGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRTGI2DCNJUGUZDQMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
amy_defaultfield to every knob definition matching AMY'sreset_osc()defaultsset_knobs_from_events()working variables from AMY defaults instead of null/0, so knobs omitted byEVENT_FROM_OSC_ARRAY(because they match reset state) still display correctlyeditor_state.json) and on Clear Patch, instead of using hardcoded knob resetsevent.Freqtypo (capital F) that prevented LFO freq from syncingevent.wave &&falsy-zero check that skipped SINE wave detectionTest plan
🤖 Generated with Claude Code