feat: Add start_updater_thread to update off the main thread #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Apr 24, 2023
This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent.
felangel
reviewed
Apr 25, 2023
felangel
reviewed
Apr 25, 2023
felangel
reviewed
Apr 25, 2023
| /// cache. The Engine calls this during boot and it will check for an update | ||
| /// and install it if available. | ||
| pub fn start_update_thread() { | ||
| // This holds the lock on the config for the entire duration of the update |
There was a problem hiding this comment.
Is there any harm in holding the lock on the config?
There was a problem hiding this comment.
There is, in that any other calls into the library will block until the lock is released. Which means that if we add a dart api those calls would hang while an update is in progress. Better is to have it drop the lock while it's doing network requests since those can go on for a long time.
felangel
approved these changes
Apr 25, 2023
This makes it so that clients can easily not block when wanting to queue an update. I have a separate patch which updates the Engine to use this new API. I also needed to split the concept of the "next_boot" patch from the "current_boot" patch, previously refered to as "current" or "active" patch. This required adding a report_launch_start api to let the updater library know when to set current_boot patch from next_boot. I also removed the rust updater/cli in this as well as the vmpath argument to init. I also exposed the report_launch_success api, but its not yet used by the Engine. I renamed report_failed_launch to report_launch_failure to match report_launch_start which I introduced.
Also added a helper for char* allocation (not sure if it's better).
Remove space Co-authored-by: Felix Angelov <felix@shorebird.dev>
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Apr 25, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Apr 26, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
May 11, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
May 11, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 22, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 22, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 22, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 22, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 24, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 24, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 26, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 26, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 30, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 30, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 30, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 30, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
May 30, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Jun 6, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Jun 6, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Jun 6, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Jun 8, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Jun 8, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Jun 8, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Jun 8, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Jun 16, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Jun 16, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Jun 22, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Jun 22, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
Closed
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Jul 13, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Jul 13, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Aug 18, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Aug 18, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Aug 24, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Aug 24, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Sep 8, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Sep 8, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Sep 19, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Sep 19, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Sep 21, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Sep 21, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Oct 2, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Oct 2, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Oct 19, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
eseidel
added a commit
to shorebirdtech/engine
that referenced
this pull request
Oct 19, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Oct 26, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
felangel
pushed a commit
to shorebirdtech/engine
that referenced
this pull request
Oct 26, 2023
* feat: Support async updates from the updater library. This is the engine side of: shorebirdtech/updater#11 I also removed passing vmpath (unused) and adjusted names to be more consistent. * Add DEPS change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that clients can easily not block when wanting to
queue an update.
I have a separate patch which updates the Engine to use this new
API.
I also needed to split the concept of the "next_boot" patch
from the "current_boot" patch, previously refered to as
"current" or "active" patch. This required adding a
report_launch_start api to let the updater library know
when to set current_boot patch from next_boot.
I also removed the rust updater/cli in this as well as the
vmpath argument to init.
I also exposed the report_launch_success api, but its not yet
used by the Engine.
I renamed report_failed_launch to report_launch_failure to match
report_launch_start which I introduced.