feat(code_push_protocol): add Collaborator model
#500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidel
reviewed
May 16, 2023
| test('can be (de)serialized', () { | ||
| const collaborator = Collaborator( | ||
| userId: 1, | ||
| email: 'jane.doe@shorebird.dev', |
There was a problem hiding this comment.
Does tying this together with email mean users can't change their email in our db?
There was a problem hiding this comment.
No they can still change their emails. The collaborators table in the db is just a join table 👍
eseidel
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Collaboratormodel (part of Make it possible for two people to collaborate on an App #216)Type of Change