Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): add Flutter 3.24.3 #2486

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
8 changes: 5 additions & 3 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,25 @@ concurrency:
cancel-in-progress: true

on:
pull_request:
workflow_dispatch:
schedule:
# At the end of every day
- cron: "0 0 * * *"

env:
SHOREBIRD_TOKEN: ${{ secrets.SHOREBIRD_TOKEN }}
FLUTTER_VERSION: 3.24.1
FLUTTER_VERSION: 3.24.3

jobs:
patch:
strategy:
fail-fast: false
matrix:
flutter-version: [3.24.1, 3.24.0, 3.22.3, 3.22.2, 3.19.6]
flutter-version: [3.24.3] #, 3.24.1, 3.24.0, 3.22.3, 3.22.2, 3.19.6]

runs-on: ubuntu-latest
timeout-minutes: 15
timeout-minutes: 30

env:
SHOREBIRD_HOSTED_URL: https://api-dev.shorebird.dev
Expand Down Expand Up @@ -86,6 +87,7 @@ jobs:
script: ./scripts/patch_e2e.sh ${{ matrix.flutter-version }}

cli:
if: false
strategy:
fail-fast: false
matrix:
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/lib/src/cache.dart
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ class BundleToolArtifact extends CachedArtifact {

@override
String get storageUrl {
return 'https://github.com/google/bundletool/releases/download/1.15.6/bundletool-all-1.15.6.jar';
return 'https://github.com/google/bundletool/releases/download/1.17.1/bundletool-all-1.17.1.jar';
}

@override
Expand All @@ -364,5 +364,5 @@ class BundleToolArtifact extends CachedArtifact {
// ```shell
// shasum --algorithm 256 /path/to/file
// ```
'''38ae8a10bcdacef07ecce8211188c5c92b376be96da38ff3ee1f2cf4895b2cb8''';
'''45881ead13388872d82c4255b195488b7fc33f2cac5a9a977b0afc5e92367592''';
}
2 changes: 1 addition & 1 deletion packages/shorebird_cli/lib/src/executables/bundletool.dart
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ class Bundletool {
final result = await _exec(
[
'build-apks',
'--connected-device',
'--overwrite',
'--bundle=$bundle',
'--output=$output',
'--mode=universal',
],
);
if (result.exitCode != 0) {
Expand Down
6 changes: 5 additions & 1 deletion scripts/patch_e2e.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,12 @@ echo "void main() { print('hello world'); }" >lib/main.dart
# Initialize Shorebird
shorebird init --force -v

# Run Flutter & Shorebird doctor to ensure that the project is set up correctly.
flutter doctor --verbose
shorebird doctor --verbose

# Point to the development environment
echo "base_url: https://api-dev.shorebird.dev" >> shorebird.yaml
echo "base_url: https://api-dev.shorebird.dev" >>shorebird.yaml

# Extract the app_id from the "shorebird.yaml"
APP_ID=$(cat shorebird.yaml | grep 'app_id:' | awk '{print $2}')
Expand Down
Loading