Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): ignore Mach-O UUID when checking for iOS patchability #1783

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

This change detects Mach-O files when diffing for an iOS patch and zeroes out the LC_UUID load command value. See the attached bug for context about why this is necessary.

Fixes #1780

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (94c4b69) to head (a1bd278).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1783   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          167       168    +1     
  Lines         5197      5220   +23     
=========================================
+ Hits          5197      5220   +23     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit 06220c9 into main Mar 8, 2024
8 checks passed
@bryanoltman bryanoltman deleted the bo/macho-uuid branch March 8, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: patch ios reports native changes if patch is run in a different folder than release
3 participants