Skip to content

fix: add Shorebird storage url as trusted source #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix: add Shorebird storage url as trusted source #64

merged 2 commits into from
Aug 30, 2024

Conversation

felangel
Copy link

This removes the warning when using Shorebird's storage url

'Flutter assets will be downloaded from https://download.shorebird.dev. Make sure you trust this source!'

@felangel felangel self-assigned this Aug 30, 2024
eseidel
eseidel approved these changes Aug 30, 2024
View reviewed changes
Copy link

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect it's better to just make download.shorebird.dev the default (instead of download.flutter.dev) for our flutter fork. That will also make the flutter e2e tests pass.

@felangel felangel merged commit 4150b0d into shorebird/dev Aug 30, 2024
3 of 4 checks passed
@felangel felangel deleted the fix/add-shorebird-as-trusted-source branch August 30, 2024 17:51
felangel added a commit that referenced this pull request Sep 4, 2024
@felangel
fix: add Shorebird storage url as trusted source (#64)
e396609
felangel added a commit that referenced this pull request Sep 12, 2024
@felangel
fix: add Shorebird storage url as trusted source (#64)
8e2379e
felangel added a commit that referenced this pull request Oct 28, 2024
@felangel
fix: add Shorebird storage url as trusted source (#64)
58f8d57
bryanoltman pushed a commit that referenced this pull request Nov 14, 2024
@felangel @bryanoltman
fix: add Shorebird storage url as trusted source (#64)
8e56086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseidel eseidel eseidel approved these changes

@bryanoltman bryanoltman Awaiting requested review from bryanoltman

Assignees

@felangel felangel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felangel @eseidel