feat: bundling the public key in the artifact for android #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidel
reviewed
May 7, 2024
eseidel
reviewed
May 7, 2024
eseidel
reviewed
May 7, 2024
Comment on lines
1198
to
1200
| def base64EncodedKey = Base64.getEncoder().encode(publicKeyFile.readBytes()); | ||
| content += 'patch_public_key: ' + new String(base64EncodedKey) + '\n'; | ||
| } |
There was a problem hiding this comment.
I think the public key just ends up as a flutter asset? Or is the idea to include the content of the key in the shorebird.yaml itself?
There was a problem hiding this comment.
The later, to include the key (as base64) into the "final" shorebird.yaml
eseidel
reviewed
May 7, 2024
|
Discussed in person, we're going to change this to expect an environment variable to have the key that we then just set in this shorebird.yaml. e.g. essentially: patch_public_key: $SHOREBIRD_PATCH_KEY |
|
We will then also have to change |
erickzanardo
commented
May 7, 2024
erickzanardo
commented
May 7, 2024
| @@ -28,7 +28,6 @@ import org.gradle.api.tasks.Optional | |||
| import org.gradle.api.tasks.TaskAction | |||
| import org.gradle.api.tasks.bundling.Jar | |||
| import org.gradle.internal.os.OperatingSystem | |||
| import org.gradle.util.VersionNumber | |||
eseidel
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to bundle a public key in the binary. Which afterwards can be used in the updater to validate patch signatures.
In this first POC we discussed to make the flow very simple. If there is a
public.pemfile in the root of the flutter project. It will be added, encoded in base64 into the "internal"shorebird.yaml.iOS change will follow.