fix: don't proceed with ConfigureShorebird if init fails #87
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
Sep 3, 2024
shell/common/shorebird/shorebird.cc
Outdated
| @@ -125,8 +125,11 @@ void ConfigureShorebird(std::string code_cache_path, | |||
| app_parameters.original_libapp_paths_size = c_paths.size(); | |||
|
|
|||
| // shorebird_init copies from app_parameters and shorebirdYaml. | |||
| shorebird_init(&app_parameters, ShorebirdFileCallbacks(), | |||
| shorebird_yaml.c_str()); | |||
| auto init_result = shorebird_init(&app_parameters, ShorebirdFileCallbacks(), | |||
There was a problem hiding this comment.
Is there any way to unit test this to ensure we don't have a regression?
eseidel
requested changes
Sep 3, 2024
|
I believe Firebase Cloud Messaging is an example of where a FlutterEngine is created (and executed) before the main thread is. I think this change as written would cause FCM to use the patch, but then the main app to use the release version? |
|
Ah, I had been testing with workmanager, which will be started by the app, but you're absolutely right (just confirmed in my FCM app test). I've updated to move the return further down, which will ensure the snapshot is properly set for the app in the FCM case. |
eseidel
reviewed
Sep 3, 2024
eseidel
approved these changes
Sep 3, 2024
Co-authored-by: Eric Seidel <eric@shorebird.dev>
felangel
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix: don't proceed with ConfigureShorebird if init fails * move return further down * Update shell/common/shorebird/shorebird.cc Co-authored-by: Eric Seidel <eric@shorebird.dev> --------- Co-authored-by: Eric Seidel <eric@shorebird.dev>
felangel
pushed a commit
that referenced
this pull request
Sep 12, 2024
* fix: don't proceed with ConfigureShorebird if init fails * move return further down * Update shell/common/shorebird/shorebird.cc Co-authored-by: Eric Seidel <eric@shorebird.dev> --------- Co-authored-by: Eric Seidel <eric@shorebird.dev>
felangel
pushed a commit
that referenced
this pull request
Oct 28, 2024
* fix: don't proceed with ConfigureShorebird if init fails * move return further down * Update shell/common/shorebird/shorebird.cc Co-authored-by: Eric Seidel <eric@shorebird.dev> --------- Co-authored-by: Eric Seidel <eric@shorebird.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
shorebird_initfails, don't proceed to report a launch start or start an update thread.Fixes shorebirdtech/updater#211