fix: use appStoragePath instead of cachesPath, as cachesPath is cleared with every release #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed with every new release
|
This will also move all the code. I'm not sure if that's what we want? (I guess we already, at least partially, guard against our cached code being used with a non-matching app? (But only based on release version, not code contents). A "better" solution might be to pass both paths down to C++/Rust and store the state.json in one and the code in another? |
|
@eseidel updated, with shorebirdtech/updater#84 |
eseidel
approved these changes
Sep 12, 2023
eseidel
pushed a commit
that referenced
this pull request
Sep 19, 2023
…ed with every release (#47) * fix: use appStoragePath instead of cachesPath, as cachesPath is cleared with every new release * Provide both app storage and code cache directory to updater * bump updater rev
eseidel
pushed a commit
that referenced
this pull request
Sep 21, 2023
…ed with every release (#47) * fix: use appStoragePath instead of cachesPath, as cachesPath is cleared with every new release * Provide both app storage and code cache directory to updater * bump updater rev
eseidel
pushed a commit
that referenced
this pull request
Oct 2, 2023
…ed with every release (#47) * fix: use appStoragePath instead of cachesPath, as cachesPath is cleared with every new release * Provide both app storage and code cache directory to updater * bump updater rev
eseidel
pushed a commit
that referenced
this pull request
Oct 19, 2023
…ed with every release (#47) * fix: use appStoragePath instead of cachesPath, as cachesPath is cleared with every new release * Provide both app storage and code cache directory to updater * bump updater rev
felangel
pushed a commit
that referenced
this pull request
Oct 26, 2023
…ed with every release (#47) * fix: use appStoragePath instead of cachesPath, as cachesPath is cleared with every new release * Provide both app storage and code cache directory to updater * bump updater rev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our
state.jsonstorage location from/data/user/0/com.example.android_clientid/code_cache/shorebird_updaterto/data/user/0/com.example.android_clientid/files/shorebird_updater. This is necessary because the code cache directory is cleared on every new release (see https://developer.android.com/reference/android/content/Context#getCodeCacheDir())Fixes shorebirdtech/shorebird#1239