Call report_failed_launch when VM fails to initialize (#3)

This will cause the updater to not recommend that patch again.
shorebirdtech · Oct 19, 2023 · efe02b2 · efe02b2
1 parent aba492e
commit efe02b2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/shell/common/BUILD.gn b/shell/common/BUILD.gn
@@ -150,6 +150,8 @@ source_set("common") {
     "//third_party/skia",
   ]
 
+  include_dirs = [ "//flutter/updater" ]
+
   if (impeller_supports_rendering) {
     sources += [
       "snapshot_controller_impeller.cc",

diff --git a/shell/common/shell.cc b/shell/common/shell.cc
@@ -41,6 +41,8 @@
 #include "third_party/skia/include/utils/SkBase64.h"
 #include "third_party/tonic/common/log.h"
 
+#include "updater.h"
+
 namespace flutter {
 
 constexpr char kSkiaChannel[] = "flutter/skia";
@@ -162,6 +164,9 @@ std::unique_ptr<Shell> Shell::Create(
   auto isolate_snapshot = DartSnapshot::IsolateSnapshotFromSettings(settings);
   auto vm = DartVMRef::Create(settings, vm_snapshot, isolate_snapshot);
   FML_CHECK(vm) << "Must be able to initialize the VM.";
+  if (!vm) {
+    shorebird_report_failed_launch();
+  }
 
   // If the settings did not specify an `isolate_snapshot`, fall back to the
   // one the VM was launched with.