Skip to content

Commit

Permalink
Call report_failed_launch when VM fails to initialize (#3)
Browse files Browse the repository at this point in the history
This will cause the updater to not recommend that patch again.
  • Loading branch information
eseidel authored and Shorebird Autoroller committed Jun 5, 2023
1 parent 76ec92c commit 99cd9cf
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion shell/common/shell.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include "third_party/skia/include/utils/SkBase64.h"
#include "third_party/tonic/common/log.h"

#include "third_party/updater/library/include/updater.h"
#include "updater.h"

namespace flutter {

Expand Down Expand Up @@ -147,6 +147,9 @@ std::unique_ptr<Shell> Shell::Create(
}
#endif
FML_CHECK(vm) << "Must be able to initialize the VM.";
if (!vm) {
shorebird_report_failed_launch();
}

// If the settings did not specify an `isolate_snapshot`, fall back to the
// one the VM was launched with.
Expand Down

0 comments on commit 99cd9cf

Please sign in to comment.