Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-37314 - Add language id lookup #27

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

DennisGarding
Copy link
Contributor

No description provided.

Copy link
Contributor

@MalteJanz MalteJanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work for your first Rust PR 👍 🎉 . I added some suggestions for improving it further 🙂

src/api/mod.rs Outdated Show resolved Hide resolved
src/api/mod.rs Outdated Show resolved Hide resolved
src/api/mod.rs Outdated Show resolved Hide resolved
src/api/mod.rs Outdated Show resolved Hide resolved
src/api/mod.rs Outdated Show resolved Hide resolved
src/api/mod.rs Outdated Show resolved Hide resolved
src/api/mod.rs Outdated Show resolved Hide resolved
@DennisGarding DennisGarding force-pushed the next-37314/language-id-lookup branch from 7f321a5 to 9ba9ffb Compare August 8, 2024 11:45
@DennisGarding DennisGarding force-pushed the next-37314/language-id-lookup branch from 9ba9ffb to 03de2a3 Compare August 8, 2024 13:59
@DennisGarding DennisGarding requested a review from MalteJanz August 8, 2024 14:00
@DennisGarding DennisGarding force-pushed the next-37314/language-id-lookup branch from 03de2a3 to d2c6067 Compare August 8, 2024 14:07
Copy link

github-actions bot commented Aug 8, 2024

Summary of the total line code coverage for the whole codebase

Total lines Covered Skipped % (pr) % (main)
1886 1070 816 56.73 55.63
Summary of each file (click to expand)
File Total lines Covered Skipped %
src/api/filter.rs 171 168 3 98.25
src/api/mod.rs 295 31 264 10.51
src/cli.rs 43 30 13 69.77
src/config_file.rs 75 55 20 73.33
src/data/export.rs 136 0 136 0.00
src/data/import.rs 137 0 137 0.00
src/data/transform/mod.rs 334 259 75 77.54
src/data/transform/script.rs 263 229 34 87.07
src/data/validate.rs 298 298 0 100.00
src/main.rs 134 0 134 0.00
More details (click to expand)

Download full HTML report

You can download the full HTML report here: click to download
Hint: You need to extract it locally and open the index.html, there you can see which lines are not covered in each file.

You can also generate these reports locally

For that, you need to install cargo-llvm-cov, then you can run:

cargo llvm-cov --all-features --no-fail-fast --open

Hint: There are also other ways to see code coverage in Rust. For example with RustRover, you can execute tests with coverage generation directly in the IDE.

Remember

Your tests should be meaningful and not just be written to raise the coverage.
Coverage is just a tool to detect forgotten code paths you may want to think about, not your instructor to write tests

Copy link
Member

@LarsKemper LarsKemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

FYI: I have created a ticket for the currency lookup: https://shopware.atlassian.net/browse/NEXT-37602

@DennisGarding DennisGarding merged commit eeeadb0 into main Aug 9, 2024
3 checks passed
@DennisGarding DennisGarding deleted the next-37314/language-id-lookup branch August 9, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants