-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEXT-37314 - Add language id lookup #27
Conversation
27b1f7c
to
7f321a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work for your first Rust PR 👍 🎉 . I added some suggestions for improving it further 🙂
7f321a5
to
9ba9ffb
Compare
9ba9ffb
to
03de2a3
Compare
03de2a3
to
d2c6067
Compare
Summary of the total line code coverage for the whole codebase
Summary of each file (click to expand)
More details (click to expand)Download full HTML reportYou can download the full HTML report here: click to download You can also generate these reports locallyFor that, you need to install cargo-llvm-cov, then you can run: cargo llvm-cov --all-features --no-fail-fast --open Hint: There are also other ways to see code coverage in Rust. For example with RustRover, you can execute tests with coverage generation directly in the IDE. RememberYour tests should be meaningful and not just be written to raise the coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
FYI: I have created a ticket for the currency lookup: https://shopware.atlassian.net/browse/NEXT-37602
No description provided.