NEXT-37313 - api client reauthentication

[ennasus4sun]

No description provided.

[MalteJanz]

Overall great work 🦀 👍

[ennasus4sun]

I tested this manually by importing a csv-file with 10.000 manufacturers and setting the expires-time of access_token_ttl in src/Core/Framework/DependencyInjection/Configuration.php to PT1S (1 second).

[MalteJanz]

Great that it worked 👍 . I added some smaller suggestions to improve / refactor the implementation a bit further 🙂

[LarsKemper]

LGTM 💪

[github-actions]

Summary of the total line code coverage for the whole codebase

Total lines	Covered	Skipped	% (pr)	% (main)
1902	1070	832	56.26	56.73

Summary of each file (click to expand)

File	Total lines	Covered	Skipped	%
src/api/filter.rs	171	168	3	98.25
src/api/mod.rs	311	31	280	9.97
src/cli.rs	43	30	13	69.77
src/config_file.rs	75	55	20	73.33
src/data/export.rs	136	0	136	0.00
src/data/import.rs	137	0	137	0.00
src/data/transform/mod.rs	334	259	75	77.54
src/data/transform/script.rs	263	229	34	87.07
src/data/validate.rs	298	298	0	100.00
src/main.rs	134	0	134	0.00

More details (click to expand)

Download full HTML report

You can download the full HTML report here: click to download
Hint: You need to extract it locally and open the index.html, there you can see which lines are not covered in each file.

You can also generate these reports locally

For that, you need to install cargo-llvm-cov, then you can run:

cargo llvm-cov --all-features --no-fail-fast --open

Hint: There are also other ways to see code coverage in Rust. For example with RustRover, you can execute tests with coverage generation directly in the IDE.

Remember

Your tests should be meaningful and not just be written to raise the coverage.
Coverage is just a tool to detect forgotten code paths you may want to think about, not your instructor to write tests

[MalteJanz]

Looks great now 👍 . Sorry for bringing up things while you still worked on it. Maybe we should introduce the same "workflow:development" labels as we have in gitlab 🤷‍♂️ .

Feel free to merge 😉