feat: add service payment integration #1010
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
packages/admin-sdk/src/index.ts
Outdated
| data, | ||
| composables, | ||
| iap, | ||
| service, |
There was a problem hiding this comment.
service as a name is too generic. We should be more specific here
| "@shopware-ag/meteor-admin-sdk": minor | ||
| --- | ||
|
|
||
| add the service payment integration |
There was a problem hiding this comment.
Documentation for this new feature is missing
| }; | ||
| }; | ||
|
|
||
| export const addPaymentIframe = async ( |
There was a problem hiding this comment.
We should avoid complex logic like this in the Meteor Admin SDK. The main purpose is to interact with the administration from an app or plugin, e.g. adding UI, etc.
Creating new iFrames within the SDK is not wanted.
|
|
||
| export const startPaymentFlow = async (): Promise<Flow> => { | ||
| await modal.open({ | ||
| locationId: servicePaymentModalLocationId, |
There was a problem hiding this comment.
The SDK methods shouldn't have dependencies on each other. Also the user doesn't know about the locationID from the modal and see then a white result. We should focus on just communicating with the admin
| --- | ||
| "@shopware-ag/meteor-admin-sdk": minor | ||
| --- | ||
|
|
There was a problem hiding this comment.
I talked privately with Quan and the following things need to be done:
- The name
serviceis too generic. I would go forpaymentto be more specific - We need integration or unit tests for these methods. The other SDK methods are just types without logic. Here it has a lot of logic we need to cover and test
- We need a detailed documentation about this feature and how to use it
What?
Wrap the utilities function for services which want to intergrate the service payment flow