Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt3-module): maintenance mode #1514

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix(nuxt3-module): maintenance mode #1514

merged 1 commit into from
Dec 6, 2024

Conversation

mdanilowicz
Copy link
Collaborator

@mdanilowicz mdanilowicz commented Dec 6, 2024

Description

This pull request replaces createError function with showError to redirect the user to the Nuxt error page to display maintenance info.

Screenshot 2024-12-06 at 10 21 31

More context about why we should use showError function can be found here nuxt/nuxt#15432

closes #1511

Type of change

ToDo's

Screenshots (if applicable)

Additional context

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Dec 6, 2024 9:21am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Dec 6, 2024 9:21am

Copy link

pkg-pr-new bot commented Dec 6, 2024

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1514

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1514

@shopware-pwa/composables-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/composables-next@1514

@shopware-pwa/cms-base

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/cms-base@1514

@shopware-pwa/helpers-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/helpers-next@1514

@shopware-pwa/nuxt3-module

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/nuxt3-module@1514

commit: d6846af

@patzick patzick merged commit 05a4792 into main Dec 6, 2024
12 checks passed
@patzick patzick deleted the fix/GH-1511-II branch December 6, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Maintenance page is not working
2 participants