Open
Conversation
Micha Hobert (Isengo1989)
requested review from
Copilot and
Michael Telgmann (mitelg)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces broken SonarSource documentation links with inline guidance from archived content. The original links to SonarSource rules documentation were returning 404 errors, so the PR substitutes them with explanatory text based on archived versions of the documentation.
Changes:
- Replaced dead SonarSource link references with inline security guidance about cross-domain messaging
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| resources/guidelines/testing/store/quality-guidelines-plugins/index.md | Replaced broken SonarSource link with inline explanation of cross-domain messaging security |
| resources/guidelines/testing/store/quality-guidelines-apps/index.md | Replaced broken SonarSource link with inline explanation of cross-domain messaging security |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### Ensure cross-domain messages are sent to the intended domain | ||
|
|
||
| Link: ["Cross-document messaging domains should be carefully restricted"](https://rules.sonarsource.com/javascript/RSPEC-2819) | ||
| When using `postMessage()` or similar cross-window messaging APIs, verify the message origin (e.g. `event.origin`) and restrict target domains to trusted URLs instead of `'*'`. This prevents malicious sites from sending or receiving messages inappropriately. |
There was a problem hiding this comment.
The word 'inappropriately' could be replaced with 'unauthorized' for clearer security-focused language.
Suggested change
| When using `postMessage()` or similar cross-window messaging APIs, verify the message origin (e.g. `event.origin`) and restrict target domains to trusted URLs instead of `'*'`. This prevents malicious sites from sending or receiving messages inappropriately. | |
| When using `postMessage()` or similar cross-window messaging APIs, verify the message origin (e.g. `event.origin`) and restrict target domains to trusted URLs instead of `'*'`. This prevents malicious sites from sending or receiving unauthorized messages. |
| ### Ensure cross-domain messages are sent to the intended domain | ||
|
|
||
| ["Cross-document messaging domains should be carefully restricted"](https://rules.sonarsource.com/javascript/RSPEC-2819) | ||
| When using `postMessage()` or similar cross-window messaging APIs, verify the message origin (e.g. `event.origin`) and restrict target domains to trusted URLs instead of `'*'`. This prevents malicious sites from sending or receiving messages inappropriately. |
There was a problem hiding this comment.
The word 'inappropriately' could be replaced with 'unauthorized' for clearer security-focused language.
Suggested change
| When using `postMessage()` or similar cross-window messaging APIs, verify the message origin (e.g. `event.origin`) and restrict target domains to trusted URLs instead of `'*'`. This prevents malicious sites from sending or receiving messages inappropriately. | |
| When using `postMessage()` or similar cross-window messaging APIs, verify the message origin (e.g. `event.origin`) and restrict target domains to trusted URLs instead of `'*'`. This prevents malicious sites from sending or receiving unauthorized messages. |
Michael Telgmann (mitelg)
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no active links anymore on that, so I searched the webarchive and added context here:
https://web.archive.org/web/20230927143646/https://rules.sonarsource.com/typescript/type/Vulnerability/RSPEC-2819/
Not sure if still needed, but better then a 404 - Sonarcube support does not answer. Rules seem to be removed.