Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Controller/LicenseController.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@ public function createCart(Request $request, Context $context): JsonResponse
$extensionId = $request->request->get('extensionId');
$variantId = $request->request->get('variantId');

if (!is_numeric($extensionId)) {
if (!\is_int($extensionId) && !\is_string($extensionId)) {
throw ExtensionStoreException::invalidExtensionId();
}

if (!is_numeric($variantId)) {
if (!\is_int($variantId) && !\is_string($variantId)) {
throw ExtensionStoreException::invalidVariantId();
}

$cart = $this->licenseService->createCart((int) $extensionId, (int) $variantId, $context);
$cart = $this->licenseService->createCart($extensionId, $variantId, $context);

return new JsonResponse($cart);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Services/LicenseService.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function __construct(StoreClient $client)
$this->client = $client;
}

public function createCart(int $extensionId, int $variantId, Context $context): CartStruct
public function createCart(int|string $extensionId, int|string $variantId, Context $context): CartStruct
{
$cart = $this->client->createCart($extensionId, $variantId, $context);

Expand Down
3 changes: 2 additions & 1 deletion src/Services/StoreClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public function extensionDetailReviews(int $id, ExtensionCriteria $criteria, Con
return json_decode((string) $response->getBody(), true);
}

public function createCart(int $extensionId, int $variantId, Context $context): CartStruct
public function createCart(int|string $extensionId, int|string $variantId, Context $context): CartStruct
{
try {
$response = $this->client->request(
Expand All @@ -157,6 +157,7 @@ public function createCart(int $extensionId, int $variantId, Context $context):
'variantId' => $variantId,
],
],
'mode' => 'newStore',
],
],
);
Expand Down
4 changes: 2 additions & 2 deletions tests/Controller/LicenseControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function testPurchaseExtensionWithInvalidExtensionId(): void
$controller = new LicenseController($this->createMock(LicenseService::class));

$request = new Request();
$request->request->set('extensionId', 'foo');
$request->request->set('extensionId', 2.4);

$this->expectException(InvalidExtensionIdException::class);
$controller->createCart($request, Context::createDefaultContext());
Expand All @@ -34,7 +34,7 @@ public function testPurchaseExtensionWithInvalidVariantId(): void

$request = new Request();
$request->request->set('extensionId', 1);
$request->request->set('variantId', 'foo');
$request->request->set('variantId', 2.4);

$this->expectException(InvalidVariantIdException::class);
$controller->createCart($request, Context::createDefaultContext());
Expand Down
Loading