fix: incorrect IAP detail result #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #106 +/- ##
============================================
+ Coverage 64.00% 68.89% +4.88%
- Complexity 0 66 +66
============================================
Files 27 35 +8
Lines 714 1064 +350
Branches 126 126
============================================
+ Hits 457 733 +276
- Misses 228 302 +74
Partials 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FlorianKe
previously approved these changes
Aug 15, 2025
lernhart
previously approved these changes
Aug 15, 2025
cyl3x
previously approved these changes
Aug 18, 2025
En0Ma1259
previously approved these changes
Aug 18, 2025
mstegmeyer
dismissed stale reviews from En0Ma1259, cyl3x, lernhart, and FlorianKe
via
1bb20e8
FlorianKe
approved these changes
Aug 20, 2025
En0Ma1259
approved these changes
Aug 20, 2025
Contributor
|
@mstegmeyer can you backport to 6.6? |
mstegmeyer
added a commit
that referenced
this pull request
Aug 21, 2025
* fix: incorrect IAP detail result * fix: remove debugging * test: add unit test * fix: cs * chore: update composer version --------- Co-authored-by: Michel <m.bade@shopware.com>
mstegmeyer
added a commit
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for weird reasons, the function from platform does not correctly filter based on the Criteria. In all other use cases, this is not important, because no Criteria is used, but in this case, first() may be a different extension.
No problem, we just do
getas the keys are luckily already the Extension.