fix: incorrect IAP detail result (#106) (#109)

* fix: incorrect IAP detail result

* fix: remove debugging

* test: add unit test

* fix: cs

* chore: update composer version

---------

Co-authored-by: Michel <m.bade@shopware.com>

Author: mstegmeyer

composer.json

@@ -1,6 +1,6 @@
 {
     "name": "swag/swag-extension-store",
-    "version": "3.1.6",
+    "version": "3.1.7",
     "description": "SWAG Extension Store",
     "type": "shopware-platform-plugin",
     "license": "MIT",

src/Controller/InAppPurchasesController.php

@@ -51,7 +51,11 @@ public function getInAppPurchaseDetails(string $technicalName, Context $context)
 
         $extension = $this->extensionDataProvider
             ->getInstalledExtensions($context, false, $criteria)
-            ->first();
+            ->get($technicalName);
+
+        if (!$extension) {
+            throw ExtensionStoreException::unknownExtension($technicalName);
+        }
 
         return new JsonResponse($extension);
     }

src/Exception/ExtensionStoreException.php

@@ -48,4 +48,14 @@ public static function invalidInAppPurchase(): self
             'The extension provider disallowed your purchase. Please contact the extension provider.',
         );
     }
+
+    public static function unknownExtension(string $technicalName): self
+    {
+        return new self(
+            Response::HTTP_NOT_FOUND,
+            'FRAMEWORK__UNKNOWN_EXTENSION',
+            'The extension with technical name "{{ technicalName }}" is not known.',
+            ['technicalName' => $technicalName],
+        );
+    }
 }

tests/Controller/InAppPurchasesControllerTest.php

@@ -33,11 +33,16 @@ public function testGetInAppFeature(): void
     {
         $extension = new ExtensionStruct();
         $extension->setName('testExtension');
+        $otherExtension = new ExtensionStruct();
+        $otherExtension->setName('otherExtension');
         $service = $this->createMock(InAppPurchasesService::class);
         $dataProvider = $this->createMock(AbstractExtensionDataProvider::class);
         $dataProvider->expects(static::once())
             ->method('getInstalledExtensions')
-            ->willReturn(new ExtensionCollection([$extension]));
+            ->willReturn(new ExtensionCollection([
+                'otherExtension' => $otherExtension,
+                'testExtension' => $extension,
+            ]));
 
         $controller = new InAppPurchasesController(
             $service,
@@ -54,6 +59,30 @@ public function testGetInAppFeature(): void
         static::assertSame('testExtension', $content['name']);
     }
 
+    public function testGetInAppFeatureWithUnknownExtension(): void
+    {
+        $extension = new ExtensionStruct();
+        $extension->setName('testExtension');
+        $service = $this->createMock(InAppPurchasesService::class);
+        $dataProvider = $this->createMock(AbstractExtensionDataProvider::class);
+        $dataProvider->expects(static::once())
+            ->method('getInstalledExtensions')
+            ->willReturn(new ExtensionCollection(['testExtension' => $extension]));
+
+        $controller = new InAppPurchasesController(
+            $service,
+            $this->createMock(InAppPurchaseUpdater::class),
+            $dataProvider,
+            $this->createMock(InAppPurchasesGateway::class),
+            $this->createMock(EntityRepository::class),
+        );
+
+        $this->expectException(ExtensionStoreException::class);
+        $this->expectExceptionMessage('The extension with technical name "otherExtension" is not known.');
+
+        $controller->getInAppPurchaseDetails('otherExtension', Context::createDefaultContext());
+    }
+
     public function testCreateCart(): void
     {
         $cartStruct = $this->getInAppPurchaseCartStruct();