fix: keep exact negative powers of ten under default precision#430
Open
Solaris-star wants to merge 1 commit into
Open
fix: keep exact negative powers of ten under default precision#430Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
DivRound with PowPrecisionNegativeExponent (16) collapsed exact values like 10**-17 to zero. When the reciprocal rounds to zero, retry with enough digits for the positive power result. Fixes shopspring#394
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pow/PowInt32/PowBigIntusedDivRound(..., PowPrecisionNegativeExponent)for negative integer exponents. With the default precision of 16, exact values such as10 ** -17became0.Fix
When the reciprocal rounds to zero, retry
DivRoundwith enough fractional digits for the positive power result (NumDigits), so exact powers of ten stay non-zero without changing rounded results that already fit in the configured precision.Test plan
go test .TestDecimal_PowNegativeIntegerPowersOfTenfor exponents -16/-17/-18/-20 via Pow/PowInt32/PowBigIntFixes #394