Freeze literal strings.

shopsmart · Nov 16, 2016 · c8ba3e3 · c8ba3e3
1 parent 63a4eca
commit c8ba3e3
Show file tree

Hide file tree

Showing 17 changed files with 19 additions and 3 deletions.
diff --git a/faraday-http-cache.gemspec b/faraday-http-cache.gemspec
@@ -1,4 +1,4 @@
-# -*- encoding: utf-8 -*-
+# frozen_string_literal: true
 Gem::Specification.new do |gem|
   gem.name          = 'faraday-http-cache'
   gem.version       = '1.3.1'

diff --git a/lib/faraday/http_cache.rb b/lib/faraday/http_cache.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'faraday'
 
 require 'faraday/http_cache/storage'
@@ -48,7 +49,7 @@ class HttpCache < Faraday::Middleware
     ERROR_STATUSES = (400..499).freeze
 
     # The name of the instrumentation event.
-    EVENT_NAME = 'http_cache.faraday'.freeze
+    EVENT_NAME = 'http_cache.faraday'
 
     CACHE_STATUSES = [
       # The request was not cacheable.

diff --git a/lib/faraday/http_cache/cache_control.rb b/lib/faraday/http_cache/cache_control.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Faraday
   class HttpCache < Faraday::Middleware
     # Internal: A class to represent the 'Cache-Control' header options.

diff --git a/lib/faraday/http_cache/request.rb b/lib/faraday/http_cache/request.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Faraday
   class HttpCache < Faraday::Middleware
     # Internal: A class to represent a request

diff --git a/lib/faraday/http_cache/response.rb b/lib/faraday/http_cache/response.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'time'
 require 'faraday/http_cache/cache_control'
 

diff --git a/lib/faraday/http_cache/storage.rb b/lib/faraday/http_cache/storage.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'json'
 require 'digest/sha1'
 

diff --git a/spec/binary_spec.rb b/spec/binary_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe Faraday::HttpCache do

diff --git a/spec/cache_control_spec.rb b/spec/cache_control_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe Faraday::HttpCache::CacheControl do

diff --git a/spec/http_cache_spec.rb b/spec/http_cache_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe Faraday::HttpCache do

diff --git a/spec/instrumentation_spec.rb b/spec/instrumentation_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'active_support'
 require 'active_support/notifications'

diff --git a/spec/json_spec.rb b/spec/json_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe Faraday::HttpCache do

diff --git a/spec/request_spec.rb b/spec/request_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe Faraday::HttpCache::Request do

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'uri'
 require 'socket'
 

diff --git a/spec/storage_spec.rb b/spec/storage_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe Faraday::HttpCache::Storage do
@@ -44,7 +45,7 @@
 
       context 'when ASCII characters in response cannot be converted to UTF-8' do
         let(:response) do
-          body = "\u2665".force_encoding('ASCII-8BIT')
+          body = String.new("\u2665").force_encoding('ASCII-8BIT')
           double(:response, serializable_hash: { 'body' => body })
         end
 

diff --git a/spec/support/test_app.rb b/spec/support/test_app.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'sinatra/base'
 require 'json'
 

diff --git a/spec/support/test_server.rb b/spec/support/test_server.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'net/http'
 
 class TestServer

diff --git a/spec/validation_spec.rb b/spec/validation_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe Faraday::HttpCache do