Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning at startup #43

Merged
merged 3 commits into from
May 4, 2020

Conversation

MRigal
Copy link
Contributor

@MRigal MRigal commented Apr 23, 2020

Fixes #42

@paddycarey
Copy link

Thanks for the PR! I'll poke Travis to run the tests and should be able to get this merged later tonight or tomorrow.

@pe224
Copy link

pe224 commented May 4, 2020

Cool! Hope this lands soon.

For me, I also needed to adapt the signature here to

    def __init__(self, fspath, parent):
        super(BlackItem, self).__init__(fspath, parent)

otherwise there was an error.

@MRigal
Copy link
Contributor Author

MRigal commented May 4, 2020

Thanks @pe224 it was indeed missing! I hope it still works fine with all older versions also, but I can't see or start the Travis jobs... @paddycarey maybe?

@paddycarey
Copy link

Sorry for the delay, this looks good to me but just having a little trouble with the travis build and required statuses. I can see that it's passed the build fine, but hasn't come through here for some reason.

I'm no longer working at shopkeep so don't have admin access to this repo to just disable the status check and merge, but I've reached out to some folks who do, so should be able to merge soon hopefully.

@MRigal
Copy link
Contributor Author

MRigal commented May 4, 2020

Thanks @paddycarey ! For all folks from Shopkeep:

Thanks for the nice work so far! In case maintenance of the project might become to heavy, you could consider transferring the plugin to the https://github.com/pytest-dev organization (keeping credits for the original work and/or adding some contributers as maintainers of this repo).

@kevincowan kevincowan merged commit f156ee5 into shopkeep:master May 4, 2020
@paddycarey
Copy link

PR's been merged, i'll get the new version out shortly, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pytest deprecation warnings
4 participants