Extract common method loadSuccess

shoothzj · Aug 2, 2021 · 97eccf1 · 97eccf1
1 parent 7b9170b
commit 97eccf1
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 8 deletions.
diff --git a/lib/vm/base_load_list_page_view_model.dart b/lib/vm/base_load_list_page_view_model.dart
@@ -19,6 +19,12 @@ abstract class BaseLoadListPageViewModel<T> extends DataTableSource {
     this.converter = converter;
   }
 
+  /// call loadSuccess to set loading to false and clear the exceptions
+  void loadSuccess() {
+    loading = false;
+    loadException = null;
+  }
+
   @override
   DataRow? getRow(int index) {
     if (converter == null) {

diff --git a/lib/vm/base_load_view_model.dart b/lib/vm/base_load_view_model.dart
@@ -6,4 +6,10 @@ class BaseLoadViewModel extends ChangeNotifier {
   Exception? loadException;
 
   Exception? opException;
+
+  /// call loadSuccess to set loading to false and clear the exceptions
+  void loadSuccess() {
+    loading = false;
+    loadException = null;
+  }
 }
diff --git a/lib/vm/pulsar/pulsar_instance_view_model.dart b/lib/vm/pulsar/pulsar_instance_view_model.dart
@@ -38,8 +38,7 @@ class PulsarInstanceViewModel
           .map((e) => PulsarTenantViewModel(pulsarInstancePo, e))
           .toList();
       this.displayList = this.fullList;
-      loadException = null;
-      loading = false;
+      loadSuccess();
     } on Exception catch (e) {
       log('request failed, $e');
       loadException = e;

diff --git a/lib/vm/pulsar/pulsar_namespace_view_model.dart b/lib/vm/pulsar/pulsar_namespace_view_model.dart
@@ -52,8 +52,7 @@ class PulsarNamespaceViewModel
               pulsarInstancePo, tenantResp, namespaceResp, e))
           .toList();
       this.displayList = this.fullList;
-      loadException = null;
-      loading = false;
+      loadSuccess();
     } on Exception catch (e) {
       loadException = e;
       loading = false;

diff --git a/lib/vm/pulsar/pulsar_partitioned_topic_view_model.dart b/lib/vm/pulsar/pulsar_partitioned_topic_view_model.dart
@@ -54,8 +54,7 @@ class PulsarTopicViewModel extends BaseLoadListViewModel<SubscriptionResp> {
           host, port, tenant, namespace, topic);
       this.fullList = results;
       this.displayList = this.fullList;
-      loadException = null;
-      loading = false;
+      loadSuccess();
     } on Exception catch (e) {
       loadException = e;
       loading = false;

diff --git a/lib/vm/pulsar/pulsar_tenant_view_model.dart b/lib/vm/pulsar/pulsar_tenant_view_model.dart
@@ -47,8 +47,7 @@ class PulsarTenantViewModel
           .map((e) => PulsarNamespaceViewModel(pulsarInstancePo, tenantResp, e))
           .toList();
       this.displayList = this.fullList;
-      loadException = null;
-      loading = false;
+      loadSuccess();
     } on Exception catch (e) {
       loadException = e;
       loading = false;