fix windows dll creation#4927
Open
vigsterkr wants to merge 9 commits into
Open
Conversation
Member
|
What’s the latest passing rate? :) |
Member
Author
|
🤷♂ i'll try to rebase today and debug the json serialization issues that i have seen in the past |
vigsterkr
force-pushed
the
windows_ci_fix
branch
from
9274622 to
ca81ec2
Compare
|
Is there any other way to install shigun on windows? I tried building from source but I don't have many of the libraries. Is there a way to download all the dependencies at once? |
Member
|
https://github.com/microsoft/vcpkg this had shogun integrated at some point |
fix windows conda environment activation
this allows us to be able to run on windows compiled with MSVC thnx to Gil
as we are using absolute path via SHOGUN_DATA variable
close istream in OutputStream test before deleting the file
vigsterkr
force-pushed
the
windows_ci_fix
branch
from
e1a8d3b to
e2772e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.