fix #4710#4793
Open
vigsterkr wants to merge 1 commit into
Open
Conversation
Closed
iglesias
reviewed
Nov 16, 2019
| if (iv.value) | ||
| { | ||
| iv.value->build_gradient_parameter_dictionary(dict); | ||
| iv.value.reset(); // need to reset it otherwise iv should be created after each iter |
iglesias
approved these changes
Nov 16, 2019
Collaborator
iglesias
left a comment
iglesias
left a comment
There was a problem hiding this comment.
Looking good.
The only thing, might be nitpicking, would be to auto&& iso auto& in the loops.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Member
|
let's keep it alive :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.