Optimized memory usage while building url path #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpp
reviewed
Jan 16, 2018
src/gitter.rs
Outdated
| @@ -47,7 +47,7 @@ impl<'a> Gitter<'a> { | |||
|
|
|||
| /// Returns the current user | |||
| pub fn get_user(&self) -> ApiResult<User> { | |||
| let full_url = self.api_base_url.to_string() + "user"; | |||
| let full_url = format!("{}user", self.api_base_url); | |||
There was a problem hiding this comment.
If I am not mistaken "URL//user" equals to "URL/user". So it is more readable to use format!("{}/user"). Also it will protect you from incorrect api_base_url if it does not contain trailing '/'.
kpp
approved these changes
Jan 18, 2018
|
Thank you for your PR. Will merge it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format!macro, because it usesString::with_capacityto create destination string.format!macro allow to callDisplaytrait implementation onCowand if it contains borrowed value, it doesn't allocate new string.