Android app crash; Pyramid variant

[matokira]

On the current Android version, the app will consistently crash when re-dealing the deck on the Pyramid variant. It's easy to reproduce the crash. Verified crash on up-to-date nothing Phone (2) and 2022-era Lenovo Tab.

[bwrightkc]

This doesn't happen in 3.6.0 (my install is built from source), but it appears that F-Droid is stuck on 3.4.1 for some reason.

[saisharan0103]

Pyramid's Android redeal path looks like the narrow failure point here: the report says re-dealing the deck consistently crashes only on that variant, and it was seen on both a Nothing Phone (2) and a 2022 Lenovo Tab. pysollib/kivy/LApp.py is the part I would inspect first, then trace how Pyramid's deck redeal state reaches the shared stack/game logic. For a PR, I would start by guarding the redeal transition and adding a focused Pyramid redeal regression check.

[bwrightkc]

This doesn't happen in 3.6.0 (my install is built from source), but it appears that F-Droid is stuck on 3.4.1 for some reason.

@joeraz I think whatever process is creating F-Droid builds from source isn't getting an updated version, as it appears that F-Droid runs an outdated version with a bug you've previously squished.

[joeraz]

Right. The original issue was resolved as part of issue #552 - it just hasn't been deployed.

To my knowledge, there isn't an automated build process that pushes the builds off to F-Droid. It's @lufebe16 who usually handles the Android releases - not sure if I have the necessary permissions for that myself. Though given that I plan to release a 3.6.1 this weekend, we can worry about this after that.