Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove functional #1937

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 30, 2023

No description provided.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a91a560) 96.90% compared to head (1854cc2) 96.90%.

Files Patch % Lines
module/Core/src/Domain/DomainService.php 88.88% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1937      +/-   ##
=============================================
- Coverage      96.90%   96.90%   -0.01%     
- Complexity      1333     1340       +7     
=============================================
  Files            247      247              
  Lines           4616     4647      +31     
=============================================
+ Hits            4473     4503      +30     
- Misses           143      144       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya force-pushed the feature/remove-functional branch from c067a32 to ae6eec2 Compare November 30, 2023 17:38
@acelaya acelaya force-pushed the feature/remove-functional branch from ae6eec2 to 1854cc2 Compare November 30, 2023 17:39
@acelaya acelaya merged commit d3570da into shlinkio:develop Nov 30, 2023
32 of 33 checks passed
@acelaya acelaya deleted the feature/remove-functional branch November 30, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant