fix: Support time zone when serializing DateTimes #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a DateTime being serialized would ignore the timezone, effectively assuming the timezone of the value was the same as the column. Instead, the timezone is now taken into account so the time can be given in any timezone and it will be converted to the timezone of the column.
njakobsen
force-pushed
the
fix-datetime-timezone-handling
branch
2 times, most recently
from
ad21ba7 to
378eb14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a DateTime being serialized would ignore the timezone, effectively assuming the timezone of the value was the same as the column.
Instead, the timezone is now taken into account so the time can be given in any timezone and it will be converted to the timezone of the column.